SM8650 is one of the platforms where board-level clocks (XO, sleep) definitions are split between the SoC dtsi file and the board file. This is not correct, as these two clocks are not a part of the SoC. Also such definitions don't fully follow the DT guidelines. Move these two clocks to the board files completely. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> --- arch/arm64/boot/dts/qcom/sm8650-hdk.dts | 22 ++++++++++++++-------- arch/arm64/boot/dts/qcom/sm8650-mtp.dts | 22 ++++++++++++++-------- arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 22 ++++++++++++++-------- arch/arm64/boot/dts/qcom/sm8650.dtsi | 10 ---------- 4 files changed, 42 insertions(+), 34 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts index f00bdff4280af22f6f8b23e33238f53c602bc169..641bd817d75439bc6a050189565437e1c5ead3b5 100644 --- a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts +++ b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts @@ -30,6 +30,20 @@ chosen { stdout-path = "serial0:115200n8"; }; + clocks { + xo_board: xo-board { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <76800000>; + }; + + sleep_clk: sleep-clk { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32000>; + }; + }; + hdmi-out { compatible = "hdmi-connector"; type = "a"; @@ -1112,10 +1126,6 @@ &sdhc_2 { status = "okay"; }; -&sleep_clk { - clock-frequency = <32000>; -}; - &swr0 { status = "okay"; @@ -1337,7 +1347,3 @@ &usb_dp_qmpphy { &usb_dp_qmpphy_out { remote-endpoint = <&pmic_glink_ss_in>; }; - -&xo_board { - clock-frequency = <76800000>; -}; diff --git a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts index 0db2cb03f252d19a1f8b171a562a8e06290c8a21..26ab08715473683082023ba53bef7ff37e1fbb83 100644 --- a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts +++ b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts @@ -28,6 +28,20 @@ chosen { stdout-path = "serial0:115200n8"; }; + clocks { + xo_board: xo-board { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <76800000>; + }; + + sleep_clk: sleep-clk { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32000>; + }; + }; + pmic-glink { compatible = "qcom,sm8650-pmic-glink", "qcom,sm8550-pmic-glink", @@ -729,10 +743,6 @@ &sdhc_2 { status = "okay"; }; -&sleep_clk { - clock-frequency = <32000>; -}; - &swr0 { status = "okay"; @@ -884,7 +894,3 @@ &usb_dp_qmpphy { &usb_dp_qmpphy_out { remote-endpoint = <&pmic_glink_ss_in>; }; - -&xo_board { - clock-frequency = <76800000>; -}; diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts index c5e8c3c2df91a49476f49832c0bd6418f4dfae3d..2a512d75d15d01b14a1eabda875f6d8fbe70a409 100644 --- a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts +++ b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts @@ -30,6 +30,20 @@ chosen { stdout-path = "serial0:115200n8"; }; + clocks { + xo_board: xo-board { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <76800000>; + }; + + sleep_clk: sleep-clk { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32000>; + }; + }; + gpio-keys { compatible = "gpio-keys"; @@ -1040,10 +1054,6 @@ &remoteproc_mpss { status = "okay"; }; -&sleep_clk { - clock-frequency = <32000>; -}; - &spi4 { status = "okay"; @@ -1320,7 +1330,3 @@ &usb_dp_qmpphy { &usb_dp_qmpphy_out { remote-endpoint = <&redriver_ss_in>; }; - -&xo_board { - clock-frequency = <76800000>; -}; diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi index 25e47505adcb790d09f1d2726386438487255824..b960d58210f8199e1f4e080ce50cd574314fa3e8 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -35,16 +35,6 @@ / { chosen { }; clocks { - xo_board: xo-board { - compatible = "fixed-clock"; - #clock-cells = <0>; - }; - - sleep_clk: sleep-clk { - compatible = "fixed-clock"; - #clock-cells = <0>; - }; - bi_tcxo_div2: bi-tcxo-div2-clk { compatible = "fixed-factor-clock"; #clock-cells = <0>; -- 2.39.5