Re: [PATCH net-next v2 0/8] net: lan969x: add RGMII support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 13. 11. 2024. 22:11, Daniel Machon wrote:
== Description:

This series is the fourth of a multi-part series, that prepares and adds
support for the new lan969x switch driver.

The upstreaming efforts is split into multiple series (might change a
bit as we go along):

         1) Prepare the Sparx5 driver for lan969x (merged)

         2) Add support for lan969x (same basic features as Sparx5
            provides excl. FDMA and VCAP, merged).

         3) Add lan969x VCAP functionality (merged).

     --> 4) Add RGMII support.

         5) Add FDMA support.

== RGMII support:

The lan969x switch device includes two RGMII interfaces (port 28 and 29)
supporting data speeds of 1 Gbps, 100 Mbps and 10 Mbps.

Details are in the commit description of the patches.

== Patch breakdown:

Patch #1 does some preparation work.

Patch #2 adds new function: is_port_rgmii() to the match data ops.

Patch #3 uses the is_port_rgmii() in a number of places.

Patch #4 uses the phy_interface_mode_is_rgmii() in a number of places.

Patch #5 adds checks for RGMII PHY modes in sparx5_verify_speeds().

Patch #6 adds registers required to configure RGMII.

Patch #7 adds RGMII implementation.

Patch #8 document RGMII delays.

To: UNGLinuxDriver@xxxxxxxxxxxxx
To: Andrew Lunn <andrew+netdev@xxxxxxx>
To: David S. Miller <davem@xxxxxxxxxxxxx>
To: Eric Dumazet <edumazet@xxxxxxxxxx>
To: Jakub Kicinski <kuba@xxxxxxxxxx>
To: Paolo Abeni <pabeni@xxxxxxxxxx>
To: Lars Povlsen <lars.povlsen@xxxxxxxxxxxxx>
To: Steen Hegelund <Steen.Hegelund@xxxxxxxxxxxxx>
To: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>
To: Russell King <linux@xxxxxxxxxxxxxxx>
To: jacob.e.keller@xxxxxxxxx
To: robh@xxxxxxxxxx
To: krzk+dt@xxxxxxxxxx
To: conor+dt@xxxxxxxxxx
Cc: devicetree@xxxxxxxxxxxxxxx
Cc: netdev@xxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx

Signed-off-by: Daniel Machon <daniel.machon@xxxxxxxxxxxxx>

Tested-by: Robert Marko <robert.marko@xxxxxxxxxx>

---
Changes in v2:

   Most changes are in patch #7. RGMII implementation has been moved to
   it's own file lan969x_rgmii.c.

   Details:

     - Use ETH_P_8021Q and ETH_P_8021AD instead of the Sparx5 provided
       equivalents (patch #7).
     - Configure MAC delays through "{rx,tx}-internal-delay-ps"
       properties (patch #7).
     - Add selectors for all the phase shifts that the hardware supports
       (instead of only 2.0 ns, patch #7).
     - Add selectors for all the port speeds (instead of only 1000 mbps.)
     - Document RGMII delays in dt-bindings.

   - Link to v1: https://lore.kernel.org/r/20241106-sparx5-lan969x-switch-driver-4-v1-0-f7f7316436bd@xxxxxxxxxxxxx

---
Daniel Machon (8):
       net: sparx5: do some preparation work
       net: sparx5: add function for RGMII port check
       net: sparx5: use is_port_rgmii() throughout
       net: sparx5: use phy_interface_mode_is_rgmii()
       net: sparx5: verify RGMII speeds
       net: lan969x: add RGMII registers
       net: lan969x: add RGMII implementation
       dt-bindings: net: sparx5: document RGMII MAC delays

  .../bindings/net/microchip,sparx5-switch.yaml      |  20 ++
  drivers/net/ethernet/microchip/lan969x/Makefile    |   2 +-
  drivers/net/ethernet/microchip/lan969x/lan969x.c   |   5 +
  drivers/net/ethernet/microchip/lan969x/lan969x.h   |  10 +
  .../net/ethernet/microchip/lan969x/lan969x_rgmii.c | 237 +++++++++++++++++++++
  .../net/ethernet/microchip/sparx5/sparx5_main.c    |  29 ++-
  .../net/ethernet/microchip/sparx5/sparx5_main.h    |   3 +
  .../ethernet/microchip/sparx5/sparx5_main_regs.h   | 145 +++++++++++++
  .../net/ethernet/microchip/sparx5/sparx5_phylink.c |   3 +
  .../net/ethernet/microchip/sparx5/sparx5_port.c    |  57 +++--
  .../net/ethernet/microchip/sparx5/sparx5_port.h    |   5 +
  11 files changed, 488 insertions(+), 28 deletions(-)
---
base-commit: 12079a59ce52e72a342c49cfacf0281213fd6f32
change-id: 20241104-sparx5-lan969x-switch-driver-4-d59b7820485a

Best regards,




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux