Re: [PATCH v3 1/3] dt-bindings: thermal: Add support for Airoha EN7581 thermal sensor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Ansuel,

On 13/11/2024 16:56, Christian Marangi wrote:
On Fri, Oct 18, 2024 at 12:48:04PM +0200, Christian Marangi wrote:
Add support for Airoha EN7581 thermal sensor and monitor. This is a
simple sensor for the CPU or SoC Package that provide thermal sensor and
trip point for hot low and critical condition to fire interrupt and
react on the abnormal state.

Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>

Any news with this series? Everything wrong with the thermal core small
patch?

I understand why you are trying to achieve this but usually it is the kernel which overloads the firmware description, not the opposite, no?

Either way, we ignore the offset/slope from tzp and use a couple of private variables offset/slope in the driver (iow do not call thermal_zone_get_offset() thermal_zone_get_slope()). Or add the thermal_zone_set_offset() and thermal_zone_set_slope() helpers.

I would prefer the first solution as for today I can not see any DT for ARM64 with the coefficients set. So may be we can consider the slope and the offset as a legacy which should be removed from sysfs and the thermal zone device parameters in a near future.

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux