On Wed, 13 Nov 2024 15:29:40 +0800, Xianwei Zhao wrote: > Add the dt-bindings for Amlogic A4 pin controller, and add a new > dt-binding header file which document the GPIO bank names of all > Amlogic subsequent SoCs. > > Acked-by: Rob Herring (Arm) <robh@xxxxxxxxxx> > Signed-off-by: Xianwei Zhao <xianwei.zhao@xxxxxxxxxxx> > --- > .../bindings/pinctrl/amlogic,meson-pinctrl-a4.yaml | 80 ++++++++++++++++++++++ > include/dt-bindings/gpio/amlogic-gpio.h | 45 ++++++++++++ > 2 files changed, 125 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-a4.yaml: patternProperties:^bank@[0-9a-f]+$:properties: 'gpio-controller' is a dependency of '#gpio-cells' from schema $id: http://devicetree.org/meta-schemas/gpios.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241113-a4_pinctrl-v6-2-35ba2401ee35@xxxxxxxxxxx The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.