On 11/9/2024 11:02 PM, Bryan O'Donoghue wrote: > On 05/11/2024 06:55, Dikshita Agarwal wrote: >> In preparation of adding H264 decode functionality, add probe and remove >> functions and platform data to initialize iris resources, which are >> clocks, interconnects, power domains, reset clocks, and clock >> frequencies used for iris hardware. >> >> Signed-off-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx> >> --- >> drivers/media/platform/qcom/Kconfig | 1 + >> drivers/media/platform/qcom/Makefile | 1 + >> drivers/media/platform/qcom/iris/Kconfig | 9 + >> drivers/media/platform/qcom/iris/Makefile | 4 + >> drivers/media/platform/qcom/iris/iris_core.h | 54 +++++ >> .../platform/qcom/iris/iris_platform_common.h | 35 +++ >> .../platform/qcom/iris/iris_platform_sm8550.c | 37 ++++ >> drivers/media/platform/qcom/iris/iris_probe.c | 237 >> +++++++++++++++++++++ >> 8 files changed, 378 insertions(+) >> >> diff --git a/drivers/media/platform/qcom/Kconfig >> b/drivers/media/platform/qcom/Kconfig >> index cc5799b9ea00..4f4d3a68e6e5 100644 >> --- a/drivers/media/platform/qcom/Kconfig >> +++ b/drivers/media/platform/qcom/Kconfig >> @@ -3,4 +3,5 @@ >> comment "Qualcomm media platform drivers" >> source "drivers/media/platform/qcom/camss/Kconfig" >> +source "drivers/media/platform/qcom/iris/Kconfig" >> source "drivers/media/platform/qcom/venus/Kconfig" >> diff --git a/drivers/media/platform/qcom/Makefile >> b/drivers/media/platform/qcom/Makefile >> index 4f055c396e04..ea2221a202c0 100644 >> --- a/drivers/media/platform/qcom/Makefile >> +++ b/drivers/media/platform/qcom/Makefile >> @@ -1,3 +1,4 @@ >> # SPDX-License-Identifier: GPL-2.0-only >> obj-y += camss/ >> +obj-y += iris/ >> obj-y += venus/ >> diff --git a/drivers/media/platform/qcom/iris/Kconfig >> b/drivers/media/platform/qcom/iris/Kconfig >> new file mode 100644 >> index 000000000000..34a2f81c5db3 >> --- /dev/null >> +++ b/drivers/media/platform/qcom/iris/Kconfig >> @@ -0,0 +1,9 @@ >> +config VIDEO_QCOM_IRIS >> + tristate "Qualcomm iris V4L2 decoder driver" >> + depends on VIDEO_DEV >> + depends on ARCH_QCOM || COMPILE_TEST >> + help >> + This is a V4L2 driver for Qualcomm iris video accelerator >> + hardware. It accelerates decoding operations on various >> + Qualcomm SoCs. >> + To compile this driver as a module choose m here. >> diff --git a/drivers/media/platform/qcom/iris/Makefile >> b/drivers/media/platform/qcom/iris/Makefile >> new file mode 100644 >> index 000000000000..7e701361492e >> --- /dev/null >> +++ b/drivers/media/platform/qcom/iris/Makefile >> @@ -0,0 +1,4 @@ >> +iris-objs += iris_platform_sm8550.o \ >> + iris_probe.o \ >> + >> +obj-$(CONFIG_VIDEO_QCOM_IRIS) += iris.o >> diff --git a/drivers/media/platform/qcom/iris/iris_core.h >> b/drivers/media/platform/qcom/iris/iris_core.h >> new file mode 100644 >> index 000000000000..dd0e2650641a >> --- /dev/null >> +++ b/drivers/media/platform/qcom/iris/iris_core.h >> @@ -0,0 +1,54 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Copyright (c) 2022-2024 Qualcomm Innovation Center, Inc. All rights >> reserved. >> + */ >> + >> +#ifndef _IRIS_CORE_H_ >> +#define _IRIS_CORE_H_ > > Its more usual to do two underscores __LIKE_SO__ > Noted. Thanks, Dikshita > Once amended. > > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > > Please remember to similarly update other headers in your series. > > --- > bod
