On 11/10/24 17:45, Andrew Jeffery wrote:
On Fri, 2024-11-08 at 08:58 -0600, Eddie James wrote:Add GPIO line names to the GPIO expander to describe DCM and VRM presence detection lines. Signed-off-by: Eddie James <eajames@xxxxxxxxxxxxx> --- arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts | 4 ++-- arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts index 5f9a46c2abb8..d504ae84db89 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts @@ -1232,8 +1232,8 @@ led-controller@60 { #gpio-cells = <2>;gpio-line-names =- "", "", "", "", "", "", "", "", - "", "", "", "", "", "", "power-config-full- load", ""; + "", "", "", "", "", "", "P10_DCM0_PRES", "P10_DCM1_PRES", + "", "", "", "", "PRESENT_VRM_DCM0_N", "PRESENT_VRM_DCM1_N", "power-config-full-load", ""; };This ends up generating checkpatch warnings about long lines when I apply it. I did a quick, incomplete and random survey of some other devicetrees, and perhaps exploding out like in [1] might help. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d85b2ad35a2ab
Oh, oops, sure thing. Thanks, Eddie
led-controller@61 {diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts index a4aec3010456..eefc69d0d032 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts @@ -1280,8 +1280,8 @@ pca_pres3: pca9552@60 { #gpio-cells = <2>;gpio-line-names =- "", "", "", "", "", "", "", "", - "", "", "", "", "", "", "power-config-full- load", ""; + "", "", "", "", "", "", "P10_DCM0_PRES", "P10_DCM1_PRES", + "", "", "", "", "PRESENT_VRM_DCM0_N", "PRESENT_VRM_DCM1_N", "power-config-full-load", "";Similarly here. Andrew