Hi mjchen, kernel test robot noticed the following build warnings: [auto build test WARNING on dtor-input/next] [also build test WARNING on dtor-input/for-linus robh/for-next soc/for-next linus/master v6.12-rc7 next-20241112] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/mjchen/dt-bindings-input-Add-Nuvoton-MA35D1-keypad/20241112-133327 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next patch link: https://lore.kernel.org/r/20241112053059.3361-3-mjchen0829%40gmail.com patch subject: [PATCH v2 2/2] input: keypad: add new keypad driver for MA35D1 config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20241112/202411122236.79vmA2JS-lkp@xxxxxxxxx/config) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241112/202411122236.79vmA2JS-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202411122236.79vmA2JS-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): In file included from drivers/input/keyboard/ma35d1_keypad.c:7: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 548 | val = __raw_readb(PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) | ^ In file included from drivers/input/keyboard/ma35d1_keypad.c:7: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ In file included from drivers/input/keyboard/ma35d1_keypad.c:7: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 585 | __raw_writeb(value, PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ >> drivers/input/keyboard/ma35d1_keypad.c:83:46: warning: shift count >= width of type [-Wshift-count-overflow] 83 | pressed_keys = key_event[0] | key_event[1] << 32; | ^ ~~ drivers/input/keyboard/ma35d1_keypad.c:84:46: warning: shift count >= width of type [-Wshift-count-overflow] 84 | released_keys = key_event[2] | key_event[3] << 32; | ^ ~~ drivers/input/keyboard/ma35d1_keypad.c:130:9: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 130 | val |= FIELD_PREP(KCOL, (keypad->kpi_col - 1)) | FIELD_PREP(KROW, (keypad->kpi_row - 1)); | ^ 8 warnings and 1 error generated. vim +83 drivers/input/keyboard/ma35d1_keypad.c 59 60 static void ma35d1_keypad_scan_matrix(struct ma35d1_keypad *keypad, unsigned int status) 61 { 62 struct input_dev *input_dev = keypad->input_dev; 63 unsigned int code; 64 unsigned int key; 65 unsigned long pressed_keys = 0, released_keys = 0; 66 unsigned int row_shift = get_count_order(keypad->kpi_col); 67 unsigned short *keymap = input_dev->keycode; 68 unsigned long key_event[4]; 69 unsigned int index; 70 71 /* Read key event status */ 72 key_event[0] = readl(keypad->mmio_base + KPI_KPE0); 73 key_event[1] = readl(keypad->mmio_base + KPI_KPE1); 74 key_event[2] = readl(keypad->mmio_base + KPI_KRE0); 75 key_event[3] = readl(keypad->mmio_base + KPI_KRE1); 76 77 /* Clear key event status */ 78 writel(key_event[0], (keypad->mmio_base + KPI_KPE0)); 79 writel(key_event[1], (keypad->mmio_base + KPI_KPE1)); 80 writel(key_event[2], (keypad->mmio_base + KPI_KRE0)); 81 writel(key_event[3], (keypad->mmio_base + KPI_KRE1)); 82 > 83 pressed_keys = key_event[0] | key_event[1] << 32; 84 released_keys = key_event[2] | key_event[3] << 32; 85 86 /* Process pressed keys */ 87 for_each_set_bit(index, &pressed_keys, KEY_EVENT_BITS) { 88 code = MATRIX_SCAN_CODE(index / 8, (index % 8), row_shift); 89 key = keymap[code]; 90 91 input_event(input_dev, EV_MSC, MSC_SCAN, code); 92 input_report_key(input_dev, key, 1); 93 } 94 95 /* Process released keys */ 96 for_each_set_bit(index, &released_keys, KEY_EVENT_BITS) { 97 code = MATRIX_SCAN_CODE(index / 8, (index % 8), row_shift); 98 key = keymap[code]; 99 100 input_event(input_dev, EV_MSC, MSC_SCAN, code); 101 input_report_key(input_dev, key, 0); 102 } 103 104 input_sync(input_dev); 105 } 106 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
