On Sunday 10 November 2024 18:44:31 Greenwich Mean Time Dragan Simic wrote: > The regulator-{min,max}-microvolt values for the vdd_gpu regulator in the > PinePhone Pro device dts file are too restrictive, which prevents the > highest GPU OPP from being used, slowing the GPU down unnecessarily. Let's > fix that by making the regulator-{min,max}-microvolt values less strict, > using the voltage range that the Silergy SYR838 chip used for the vdd_gpu > regulator is actually capable of producing. [1][2] > > This also eliminates the following error messages from the kernel log: > > core: _opp_supported_by_regulators: OPP minuV: 1100000 maxuV: 1150000, not > supported by regulator panfrost ff9a0000.gpu: _opp_add: OPP not supported > by regulators (800000000) > > These changes to the regulator-{min,max}-microvolt values make the PinePhone > Pro device dts consistent with the dts files for other Rockchip > RK3399-based boards and devices. It's possible to be more strict here, by > specifying the regulator-{min,max}-microvolt values that don't go outside > of what the GPU actually may use, as the consumer of the vdd_gpu regulator, > but those changes are left for a later directory-wide regulator cleanup. > Ive tested this on my PPP and can provide the following outputs. On a device without the patch: # cat /sys/class/devfreq/ff9a0000.gpu/trans_stat