On 11/11/24 2:02 PM, Pratyush Yadav wrote: > On Tue, Oct 29 2024, Tudor Ambarus wrote: > >> From: Peng Fan <peng.fan@xxxxxxx> >> >> SPI NOR flashes needs power supply to work properly. The power supply >> maybe software controllable per board design. So add the support >> for an vcc-supply regulator. >> >> Signed-off-by: Peng Fan <peng.fan@xxxxxxx> >> Reviewed-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> >> [ta: move devm_regulator_get_enable() to spi_nor_probe(). Add local dev >> variable to avoid dereferences.] >> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> > > Reviewed-by: Pratyush Yadav <pratyush@xxxxxxxxxx> > thanks, Pratyush. I sent a v5 here, where I introduce the temporary variable to struct device in its dedicated patch. Would you mind adding the R-b tag there? https://lore.kernel.org/linux-mtd/20241111111946.9048-1-tudor.ambarus@xxxxxxxxxx/ btw, I try to keep patchwork in sync, so you can see the status of patches there as well: https://patchwork.ozlabs.org/project/linux-mtd/list/?series=&submitter=&state=&q=spi-nor&archive=&delegate= Thanks!