> Subject: Re: [PATCH net-next 1/2] dt-bindings: net: dsa: microchip: Add SGMII port > support to KSZ9477 switch > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content > is safe > > On Fri, Nov 08, 2024 at 05:56:32PM -0800, Tristram.Ha@xxxxxxxxxxxxx wrote: > > From: Tristram Ha <tristram.ha@xxxxxxxxxxxxx> > > > > Update the KSZ9477 switch example to use SFP cage for SGMII support. > > Why? That's just an example. Why do we want it? Why no changes to > bindings? Your commit msg must answer to all these. As the added SGMII support needs the correct device tree declaration to activate the SFP code, users may need that to use the port. However the driver can operate the port without that code, if the current patch is accepted. But if you say it is not necessary then it is better to not change the file.
