On Fri, Nov 08, 2024 at 05:56:33PM -0800, Tristram.Ha@xxxxxxxxxxxxx wrote: > From: Tristram Ha <tristram.ha@xxxxxxxxxxxxx> > > The SGMII module of KSZ9477 switch can be setup in 3 ways: 0 for direct > connect, 1 for 1000BaseT/1000BaseX SFP, and 2 for 10/100/1000BaseT SFP. This naming is rather odd. First off, i would drop 'SFP'. It does not have to be an SFP on the other end, it could be another switch for example. 1 is PHY_INTERFACE_MODE_1000BASEX and 2 is PHY_INTERFACE_MODE_SGMII. > SFP is typically used so the default is 1. The driver can detect > 10/100/1000BaseT SFP and change the mode to 2. phylink will tell you want mode to use. I would ignore what the hardware detects, so this driver is just the same as every other driver, making it easier to maintain. Andrew
