Re: [PATCH v2 2/4] hwmon: tmp108: Add help function tmp108_common_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/8/24 15:55, Guenter Roeck wrote:
On 11/8/24 14:26, Frank Li wrote:
Add help function tmp108_common_probe() to pave road to support i3c for

help -> helper

P3T1085(NXP) chip.

Using dev_err_probe() simple code.

Use dev_err_probe() to simplify the code.


Add compatible string "nxp,p3t1085".


This is borderline and problematic. First, it is the one functional change,
and second, that functional change is not mentioned in the subject. At the very
least it needs to be mentioned in the subject. I would, however, prefer two
separate patches, even if that is just a one-liner.

I forgot: The additional chip support should also be mentioned in Kconfig and in
Documentation/hwmon/tmp108.rst.

Thanks,
Guenter





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux