Re: [PATCH 3/3] arm64: dts: qcom: x1e80100-pmics: Add missing #address-cells/#size-cells to pmk8550_pon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 9 Nov 2024 at 00:05, Abel Vesa <abel.vesa@xxxxxxxxxx> wrote:
>
> The commit 4b28a0dec185 ("of: WARN on deprecated #address-cells/#size-cells
> handling") now forces the parent nodes to specify #adddress-cells
> and #size-cells, otherwise it will throw a warning.
>
> So add the #address-cells and #size-cells properties to the pmk8550_pon node
> to get rid of those warnings.
>
> Cc: <stable+noautosel@xxxxxxxxxx> # Depends on commit 4b28a0dec185
> Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs")
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
> index 5b54ee79f048e3208cbcd6f91e0cec073420fe63..5b9d67c340dc7a4550c9c7f16269542e400e4ee4 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
> @@ -205,6 +205,9 @@ pmk8550_pon: pon@1300 {
>                         reg = <0x1300>, <0x800>;
>                         reg-names = "hlos", "pbs";
>
> +                       #address-cells = <1>;

This is incorrect, nodes under pon don't have reg and don't use addressing.

> +                       #size-cells = <0>;
> +
>                         pon_pwrkey: pwrkey {
>                                 compatible = "qcom,pmk8350-pwrkey";
>                                 interrupts = <0x0 0x13 0x7 IRQ_TYPE_EDGE_BOTH>;
>
> --
> 2.34.1
>


-- 
With best wishes
Dmitry




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux