On 11/8/24 22:56, Rob Herring wrote: > On Fri, Nov 8, 2024 at 2:31 PM Ivaylo Ivanov > <ivo.ivanov.ivanov1@xxxxxxxxx> wrote: >> >> >> >> On 11/8/24 14:16, Krzysztof Kozlowski wrote: >>> On Thu, Nov 07, 2024 at 04:34:31PM +0200, Ivaylo Ivanov wrote: >>>> Convert the Actions Semi Owl CMU bindings to DT schema. >>>> >>>> Changes during conversion: >>>> - Since all Actions Semi Owl SoCs utilize the internal low frequency >>>> oscillator as a parent for some clocks, require it. >>>> >>>> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx> >>> <form letter> >>> This is a friendly reminder during the review process. >>> >>> It looks like you received a tag and forgot to add it. >>> >>> If you do not know the process, here is a short explanation: Please add >>> Acked-by/Reviewed-by/Tested-by tags when posting new versions, under >>> or above your Signed-off-by tag. Tag is "received", when provided >>> in a message replied to you on the mailing list. Tools like b4 can help >>> here. However, there's no need to repost patches *only* to add the tags. >>> The upstream maintainer will do that for tags received on the version >>> they apply. >>> >>> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 >>> >>> If a tag was not added on purpose, please state why and what changed. >>> </form letter> >>> >>> I cannot add other people's tags - toolsets ignore it. >>> >>> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> >>> >>> ... >>> >>>> +maintainers: >>>> + - Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> >>>> + >>>> +description: | >>>> + The Actions Semi Owl Clock Management Unit generates and supplies clock >>>> + to various controllers within the SoC. >>>> + >>>> + See also:: >>> Single ':'. >> $ rg --files-with-matches "See also:" | wc -l >> 110 >> >> $ rg --files-with-matches "See also::" | wc -l >> 94 >> >> Having 94 matches of that out of all 110 definitely leads me to >> think that this has been done on purpose, and is still being done. > 91 are QCom and 82 are QCom clock bindings... They tend to be > annoyingly consistent sometimes with whatever was their downstream > coding standards. > > The double colon is needed in rSt documents to escape a colon. We > don't need that in YAML though. There were some thoughts on embedding > rSt into the bindings for generating documentation from the bindings, > but that's never been more than some experiments. This just looks like > the first QCom clock binding did this and all the others just > copy-n-pasted it. I see, thanks for the explanation! >> Could you elaborate a bit more? If it's wrong, then shouldn't we >> clean all the other bindings from that mistake? > Patches welcome... Will look further into it the following weeks. For now I'll send a v4 of this patch with the issue fixed. Best regards, Ivo. > > Rob
