Hi Pavel, On Fri, Apr 03, 2015 at 10:23:44AM +0200, Pavel Machek wrote: > Hi! > > > Hi Pawel, > > I'm still Pavel. v, not w. I know too many Pawels. Sorry about that. :-) > > > > > Hi Pawel, > > > > > A corresponding change to the N900 dts would be very nice. > > > > > > Corresponding change to the dts will come in separate patch. Or do you > > > have n900 for testing? > > > > Yes, it should be a separate patch, I agree. > > > > I do have one but I can't say when I'd have time to test it. I'm fine with > > you having tested it though. > > > > > > I think you're missing change to adp1653_i2c_driver.driver.of_match_table. > > > > > > It actually worked for me, which means device tree somehow does it > > > magic. > > > > By magic? :-) It probably just ends up comparing the device and the driver > > names. How about adding the of_match_table? > > I guess it uses adp1653_id_table. I'd hade to add redundand > information, because if it would just mask the errors if the code > changed... Indeed, that's true. This is comparing "adp1653" vs. comparing "adi,adp1653". I think I still prefer the latter since it's got also the vendor prefix included. Suppose we change this later and someone misspelled the vendor prefix --- their board would break. -- Regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
