On Wed, Nov 06, 2024 at 10:29:19AM +0000, Lee Jones wrote: > On Tue, 05 Nov 2024, kernel test robot wrote: > > > Hi Marek, > > > > kernel test robot noticed the following build errors: > > > > [auto build test ERROR on linus/master] > > [also build test ERROR on v6.12-rc6] > > [cannot apply to lee-leds/for-leds-next robh/for-next next-20241104] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Marek-Beh-n/turris-omnia-mcu-interface-h-Move-command-execution-function-to-global-header/20241104-223435 > > base: linus/master > > patch link: https://lore.kernel.org/r/20241104141924.18816-8-kabel%40kernel.org > > patch subject: [PATCH leds v5 07/12] leds: turris-omnia: Notify sysfs on MCU global LEDs brightness change > > config: arm-randconfig-003-20241105 (https://download.01.org/0day-ci/archive/20241105/202411051138.jzDE6sBH-lkp@xxxxxxxxx/config) > > compiler: arm-linux-gnueabi-gcc (GCC) 14.1.0 > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241105/202411051138.jzDE6sBH-lkp@xxxxxxxxx/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202411051138.jzDE6sBH-lkp@xxxxxxxxx/ > > > > All errors (new ones prefixed by >>): > > > > arm-linux-gnueabi-ld: drivers/leds/leds-turris-omnia.o: in function `omnia_cmd_set_color': > > >> include/linux/turris-omnia-mcu-interface.h:275:(.text+0x5a): undefined reference to `omnia_cmd_write_read' > > arm-linux-gnueabi-ld: drivers/leds/leds-turris-omnia.o: in function `omnia_cmd_read_u16': > > include/linux/turris-omnia-mcu-interface.h:311:(.text+0xaa): undefined reference to `omnia_cmd_write_read' > > arm-linux-gnueabi-ld: drivers/leds/leds-turris-omnia.o: in function `gamma_correction_show': > > include/linux/turris-omnia-mcu-interface.h:311:(.text+0x1a2): undefined reference to `omnia_cmd_write_read' > > arm-linux-gnueabi-ld: drivers/leds/leds-turris-omnia.o: in function `omnia_cmd_write_u8': > > include/linux/turris-omnia-mcu-interface.h:275:(.text+0x1c8): undefined reference to `omnia_cmd_write_read' > > arm-linux-gnueabi-ld: drivers/leds/leds-turris-omnia.o: in function `brightness_show': > > include/linux/turris-omnia-mcu-interface.h:311:(.text+0x4c2): undefined reference to `omnia_cmd_write_read' > > > > > > vim +275 include/linux/turris-omnia-mcu-interface.h > > > > 9f74fe5691025f Marek Behún 2024-11-04 267 > > 9f74fe5691025f Marek Behún 2024-11-04 268 int omnia_cmd_write_read(const struct i2c_client *client, > > 9f74fe5691025f Marek Behún 2024-11-04 269 void *cmd, unsigned int cmd_len, > > 9f74fe5691025f Marek Behún 2024-11-04 270 void *reply, unsigned int reply_len); > > 9f74fe5691025f Marek Behún 2024-11-04 271 > > 9f74fe5691025f Marek Behún 2024-11-04 272 static inline int omnia_cmd_write(const struct i2c_client *client, void *cmd, > > 9f74fe5691025f Marek Behún 2024-11-04 273 unsigned int len) > > 9f74fe5691025f Marek Behún 2024-11-04 274 { > > 9f74fe5691025f Marek Behún 2024-11-04 @275 return omnia_cmd_write_read(client, cmd, len, NULL, 0); > > 9f74fe5691025f Marek Behún 2024-11-04 276 } > > 9f74fe5691025f Marek Behún 2024-11-04 277 > > Is this real or a false positive? It is real. Happens when LEDS_TURRIS_OMNIA=y and TURRIS_OMNIA_MCU=m. LEDS_TURRIS_OMNIA must depend on both TURRIS_OMNIA_MCU and TURRIS_OMNIA_MCU_GPIO, not just the latter.
