On Fri, Nov 8, 2024, at 11:31, Niko Pasaloukos wrote:
> Adds support for the Blaize CB2 development board based on
> BLZP1600 SoC. This consists of a Carrier-Board-2 and a SoM.
>
> The blaize-blzp1600.dtsi is the common part for the SoC,
> blaize-blzp1600-som.dtsi is the common part for the SoM and
> blaize-blzp1600-cb2.dts is the board specific file.
The split of files seems fine, but a little more information
about what this chip is used for would help, so that developers
looking at the git history later can have an idea.
> Checkpatch: ignore
> Resolves: PESW-2604
I don't understand these, can you turn these into full
english sentences? What checkpatch errors do you see and
why should I ignore them? What is PESW-2604 and how does
it relate to PLZP1600?
> +#include "blaize-blzp1600-som.dtsi"
> +#include <dt-bindings/net/ti-dp83867.h>
I don't see any references to ti-dp83867.h here, maybe leave
the #include to a later patch that actually starts using it?
> +#include "blaize-blzp1600.dtsi"
> +
> +/ {
> + memory@0 {
> + device_type = "memory";
> + reg = <0x0 0x00000000 0xffffffff>;
> + };
> +};
Is this an off-by-one error or do you intentionally
leave out the last bit of the 4GB address space?
If the last byte is actually addressable, please just
use #size-cells=<2> and make it the full 0x100000000.
Arnd
