On Thu, Nov 07, 2024 at 11:17:14AM +0100, Krzysztof Kozlowski wrote:
> On Thu, Nov 07, 2024 at 10:19:54AM +0100, Marcus Folkesson wrote:
> > Convert the bindings to yaml format.
> >
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@xxxxxxxxx>
> > ---
> > .../devicetree/bindings/mtd/davinci-nand.txt | 94 ---------------
> > .../devicetree/bindings/mtd/ti,davinci-nand.yaml | 134 +++++++++++++++++++++
> > 2 files changed, 134 insertions(+), 94 deletions(-)
>
> ...
>
> > +allOf:
> > + - $ref: nand-controller.yaml
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - ti,davinci-nand
> > + - ti,keystone-nand
> > +
> > + reg:
> > + items:
> > + - description:
> > + Access window.
>
> Merge two lines. See other files how they do it.
Ok
>
> > + - description:
> > + AEMIF control registers
>
> Merge two lines
Ok
>
> > +
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 0
>
> These two properties are not needed, drop. I don't understand why did
> they appear here. Changelog also does no explain it.
Ok, I drop those.
[...]
> > +examples:
> > + - |
> > + bus {
> > + #address-cells = <2>;
> > + #size-cells = <1>;
> > +
> > + nand-controller@2000000,0 {
> > + compatible = "ti,davinci-nand";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0 0x02000000 0x02000000
> > + 1 0x00000000 0x00008000>;
>
> Two items must be encoded as two items, so two <> <>
> Also messed alignment. See DTS coding style.
Ok
>
> > +
> > + ti,davinci-chipselect = <1>;
> > + ti,davinci-mask-ale = <0>;
> > + ti,davinci-mask-cle = <0>;
> > + ti,davinci-mask-chipsel = <0>;
> > +
> > + ti,davinci-nand-buswidth = <16>;
> > + ti,davinci-ecc-mode = "hw";
> > + ti,davinci-ecc-bits = <4>;
> > + ti,davinci-nand-use-bbt;
> > +
> > + partitions {
>
> Where are the partitions documented? In which binding? Don't you miss
> mtd.yaml? I think this binding misses some references, but I am not sure
> which ones.
I thought this covered it?
+ partitions:
+ $ref: /schemas/mtd/partitions/partitions.yaml
>
> Best regards,
> Krzysztof
>
Thanks,
Marcus Folkesson
Attachment:
signature.asc
Description: PGP signature
