On Fri, Oct 11, 2024 at 07:16:21PM -0400, Jonathan Marek wrote: > These 3 controllers support OTG and the driver requires the usb-role-switch > property to enable OTG. Add the property to enable OTG by default. > > Signed-off-by: Jonathan Marek <jonathan@xxxxxxxx> > --- > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) For some reason commit f042bc234c2e ("arm64: dts: qcom: x1e80100: enable OTG on USB-C controllers") seems to break UCSI on X1E80100 CRD: [ 34.479352] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: PPM init failed, stop trying > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > index 7778e17fb2610..fb16047d803c9 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > @@ -4199,6 +4199,8 @@ usb_1_ss2_dwc3: usb@a000000 { > > dma-coherent; > > + usb-role-switch; > + > ports { > #address-cells = <1>; > #size-cells = <0>; > @@ -4452,6 +4454,8 @@ usb_1_ss0_dwc3: usb@a600000 { > > dma-coherent; > > + usb-role-switch; > + > ports { > #address-cells = <1>; > #size-cells = <0>; > @@ -4550,6 +4554,8 @@ usb_1_ss1_dwc3: usb@a800000 { > > dma-coherent; > > + usb-role-switch; > + > ports { > #address-cells = <1>; > #size-cells = <0>; > -- > 2.45.1 > -- With best wishes Dmitry