On 06/11/2024 08:19, Stanislav Jakubek wrote: > On Tue, Nov 05, 2024 at 10:03:16AM +0100, Krzysztof Kozlowski wrote: >> On Mon, Nov 04, 2024 at 02:03:58PM +0100, Stanislav Jakubek wrote: >>> While the bindings have always used the correct 'battery-detect-gpios' >>> property, the DTS and the Linux driver have been using the incorrect >>> 'bat-detect-gpio' property. Document this property and mark it >>> as deprecated. >> >> Well, I would just correct bindings instead - much less changes needed. >> Document 'bat-detect-gpios' (note the 's') and drop >> 'battery-detect-gpios'. > > Hi Krzysztof, > > this approach was preferred by one of the Spreadtrum maintainers [1], > so I did it this way. > > [1] https://lore.kernel.org/lkml/CAAfSe-uC+G8iEk_37vBr3+dQsv4a4tTTsz11hUguVRnU=r+4qQ@xxxxxxxxxxxxxx/ Wow, really? But that advice affects users of DTS... OK, I don't want to stop your fix for that, so let's get this done: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> (But I am not happy so I don;t want above ack to be used against me in the future :) ) Best regards, Krzysztof
