Hi, Shu-hsiang:
On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> Introduces the driver of the MediaTek Sensor Interface,
> focusing on integration with the MediaTek ISP CAMSYS. The
> seninf device bridges camera sensors and the ISP system,
> providing management for sensor data routing and processing.
> Key features include V4L2 framework control, and dynamic
> handling of stream configurations and virtual channels.
>
> Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@xxxxxxxxxxxx>
> ---
[snip]
> +static int get_pixel_rate(struct seninf_ctx *ctx, struct v4l2_subdev *sd,
> + s64 *result)
> +{
> + struct v4l2_ctrl *ctrl;
> +
> + ctrl = v4l2_ctrl_find(sd->ctrl_handler, V4L2_CID_PIXEL_RATE);
V4L2_CID_PIXEL_RATE is never set, so this function is redundant. Drop this function.
Regards,
CK
> + if (!ctrl) {
> + dev_info(ctx->dev, "no pixel rate in subdev %s\n", sd->name);
> + return -EINVAL;
> + }
> +
> + *result = v4l2_ctrl_g_ctrl_int64(ctrl);
> +
> + return 0;
> +}
> +
