Hi Vicentiu, kernel test robot noticed the following build errors: [auto build test ERROR on lee-leds/for-leds-next] [also build test ERROR on robh/for-next linus/master v6.12-rc6 next-20241105] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Vicentiu-Galanopulo/dt-bindings-leds-Add-LED1202-LED-Controller/20241106-001305 base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next patch link: https://lore.kernel.org/r/20241105161041.4813-3-vicentiu.galanopulo%40remote-tech.co.uk patch subject: [PATCH 3/3] [PATCH v5] leds: Add LED1202 I2C driver config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20241106/202411060859.fqkOY75Z-lkp@xxxxxxxxx/config) compiler: alpha-linux-gcc (GCC) 13.3.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241106/202411060859.fqkOY75Z-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202411060859.fqkOY75Z-lkp@xxxxxxxxx/ All error/warnings (new ones prefixed by >>): drivers/leds/leds-st1202.c: In function 'st1202_dt_init': >> drivers/leds/leds-st1202.c:350:49: warning: missing terminating " character 350 | dev_err_probe(dev, err, "Failed to register LED class dev, | ^ >> drivers/leds/leds-st1202.c:350:49: error: missing terminating " character 350 | dev_err_probe(dev, err, "Failed to register LED class dev, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/leds/leds-st1202.c:351:41: error: 'error' undeclared (first use in this function); did you mean 'err'? 351 | error: %d\n", err); | ^~~~~ | err drivers/leds/leds-st1202.c:351:41: note: each undeclared identifier is reported only once for each function it appears in >> drivers/leds/leds-st1202.c:351:46: error: expected ')' before ':' token 351 | error: %d\n", err); | ^ | ) drivers/leds/leds-st1202.c:350:38: note: to match this '(' 350 | dev_err_probe(dev, err, "Failed to register LED class dev, | ^ >> drivers/leds/leds-st1202.c:351:50: error: stray '\' in program 351 | error: %d\n", err); | ^ drivers/leds/leds-st1202.c:351:52: warning: missing terminating " character 351 | error: %d\n", err); | ^ drivers/leds/leds-st1202.c:351:52: error: missing terminating " character 351 | error: %d\n", err); | ^~~~~~~~ >> drivers/leds/leds-st1202.c:352:36: error: expected ';' before '}' token 352 | return err; | ^ | ; 353 | } | ~ vim +350 drivers/leds/leds-st1202.c 318 319 static int st1202_dt_init(struct st1202_chip *chip) 320 { 321 struct device *dev = &chip->client->dev; 322 struct st1202_led *led; 323 int err, reg; 324 325 for_each_available_child_of_node_scoped(dev_of_node(dev), child) { 326 struct led_init_data init_data = {}; 327 328 err = of_property_read_u32(child, "reg", ®); 329 if (err) { 330 of_node_put(child); 331 return dev_err_probe(dev, err, "Invalid register, error: %d\n", err); 332 } 333 334 led = &chip->leds[reg]; 335 led->is_active = true; 336 led->fwnode = of_fwnode_handle(child); 337 338 led->led_cdev.max_brightness = U8_MAX; 339 led->led_cdev.brightness_set_blocking = st1202_led_set; 340 led->led_cdev.pattern_set = st1202_led_pattern_set; 341 led->led_cdev.pattern_clear = st1202_led_pattern_clear; 342 led->led_cdev.default_trigger = "pattern"; 343 344 init_data.fwnode = led->fwnode; 345 init_data.devicename = "st1202"; 346 init_data.default_label = ":"; 347 err = devm_led_classdev_register_ext(dev, 348 &led->led_cdev, &init_data); 349 if (err < 0) { > 350 dev_err_probe(dev, err, "Failed to register LED class dev, > 351 error: %d\n", err); > 352 return err; 353 } 354 led->led_cdev.brightness_set = st1202_brightness_set; 355 led->led_cdev.brightness_get = st1202_brightness_get; 356 } 357 358 return 0; 359 } 360 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki