Hi Krzysztof, On Tue, Oct 08, 2024 at 03:23:10PM +0200, Krzysztof Kozlowski wrote: > On Tue, Oct 08, 2024 at 01:18:04PM +0200, Alain Volmat wrote: > > Addition of the stm32 csi controller driver > > This is supposed to be about hardware, not driver. Missing full stop. Ok, commit message corrected in the upcoming v2. > > > > > Signed-off-by: Alain Volmat <alain.volmat@xxxxxxxxxxx> > > --- > > .../devicetree/bindings/media/st,stm32-csi.yaml | 129 +++++++++++++++++++++ > > Use compatible as filename. Fixed > > > 1 file changed, 129 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/media/st,stm32-csi.yaml b/Documentation/devicetree/bindings/media/st,stm32-csi.yaml > > new file mode 100644 > > index 000000000000..71e7c51be58c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/st,stm32-csi.yaml > > @@ -0,0 +1,129 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/st,stm32-csi.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: STMicroelectronics STM32 CSI controller > > + > > +description: > > + The STM32 CSI controller allows connecting a CSI based > > + camera to the DCMIPP camera pipeline. > > + > > +maintainers: > > + - Alain Volmat <alain.volmat@xxxxxxxxxxx> > > + > > +properties: > > + compatible: > > + enum: > > + - st,stm32mp25-csi > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 3 > > + > > + clock-names: > > + items: > > + - const: pclk > > + - const: txesc > > + - const: csi2phy > > + > > + resets: > > + maxItems: 1 > > + > > + vdd-supply: > > + description: Digital core power supply (0.91V) > > + > > + vdda18-supply: > > + description: System analog power supply (1.8V) > > + > > + access-controllers: > > + minItems: 1 > > + maxItems: 2 > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > + description: > > + Input port node > > + > > + properties: > > + endpoint: > > + $ref: video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + data-lanes: > > + description: > > + Indicate the number of data-lanes and their mapping. > > + > > + items: > > Drop Done > > ... and test your patches. Mailing list is not the place to test them. > Your machine is. I did, however my dtschema was too old hence not reporting the issue. Once updated I now got the error reported and fixed that. > > > + minItems: 1 > > + items: > > + - const: 1 > > + - const: 2 > > + > > + required: > > + - data-lanes > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: > > + Output port node > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - clock-names > > + - resets > > + - ports > > Best regards, > Krzysztof > Regards, Alain
