On Fri, Nov 01, 2024 at 04:47:17PM +0800, Shawn Guo wrote:
> On Fri, Oct 18, 2024 at 02:31:16PM -0400, Frank Li wrote:
> > Remove #address-cells and #size-cells of eeprom@a4 because no children
> > nodes under eeprom@a4.
>
> Hmm, bindings/nvmem/zii,rave-sp-eeprom.txt suggests there could be child
> nodes?
"Data cells are child nodes of eerpom node, bindings for which are
documented in Documentation/devicetree/bindings/nvmem/nvmem.txt"
It should be optional property to declear offset, such as mac_address, or
watchdog_timeout value.
Here is no children nodes under eeprom@a4, so needn't #address-cells. It
should be added only when add children nodes.
Frank
>
> Shawn
>
> >
> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > index 0c960efd9b3d5..c7bbba45f3685 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > @@ -517,8 +517,6 @@ eeprom@a3 {
> > eeprom@a4 {
> > compatible = "zii,rave-sp-eeprom";
> > reg = <0xa4 0x4000>;
> > - #address-cells = <1>;
> > - #size-cells = <1>;
> > zii,eeprom-name = "main-eeprom";
> > };
> > };
> > --
> > 2.34.1
> >
>
