On 11/4/24 21:03, Conor Dooley wrote:
> On Mon, Nov 04, 2024 at 05:31:08PM +0200, Ivaylo Ivanov wrote:
>> + soc {
>> + #address-cells = <2>;
>> + #size-cells = <2>;
> FWIW, you could drop these two if...
I see, although the point of this was to keep it the example as close
to the original usage in s900.dtsi as possible. Anyways, if a v2 is
needed, I can do that.
Thanks for the review!
Best regards, Ivo.
>
>> + cmu: clock-controller@e0160000 {
>> + compatible = "actions,s900-cmu";
>> + reg = <0x0 0xe0160000 0x0 0x1000>;
> ...you dropped the 0x0s from here.
>
> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>
> Cheers,
> Conor.
