On 04/11/2024 14:01, Troy Mitchell wrote: > > On 2024/10/31 16:00, Krzysztof Kozlowski wrote: >> On Tue, Oct 29, 2024 at 04:36:00PM +0800, Troy Mitchell wrote: >>> On 2024/10/28 15:38, Krzysztof Kozlowski wrote: >>>> On Mon, Oct 28, 2024 at 01:32:19PM +0800, Troy Mitchell wrote: >>>>> The I2C of K1 supports fast-speed-mode and high-speed-mode, >>>>> and supports FIFO transmission. >>>>> >>>>> Signed-off-by: Troy Mitchell <TroyMitchell988@xxxxxxxxx> >>>>> --- > Change in v2: > - Change the maxItems of reg from 1 to 2 in properties Why? > - Change 'i2c' to 'I2C' in the commit message. > - Drop fifo-disable property > - Drop alias in dts example > - Move `unevaluatedProperties` after `required:` block Rest look ok. Best regards, Krzysztof