Hello Lee, this is v5 of Turris Omnia LED driver changes. v1 to v4 can be found at https://lore.kernel.org/linux-leds/20240902124104.14297-1-kabel@xxxxxxxxxx/ https://lore.kernel.org/linux-leds/20240903101930.16251-1-kabel@xxxxxxxxxx/ https://lore.kernel.org/linux-leds/20240913123103.21226-1-kabel@xxxxxxxxxx/ https://lore.kernel.org/linux-leds/20241029135621.12546-1-kabel@xxxxxxxxxx/ Changes since v4: - patch 2: correctly get MCU I2C device with device_find_child() when trying to determine features supported by MCU firmware - patch 7: don't select TURRIS_OMNIA_MCU_GPIO, depend on it instead. Selecting it causes kernel test robot to warn on some unmet dependencies since GPIOLIB is dependency for TURRIS_OMNIA_MCU_GPIO - patch 7: request brighhtness changed IRQ only if it is defined in the device-tree - patch 7: fix check for return value of devm_request_threaded_irq() Marek Marek Behún (12): turris-omnia-mcu-interface.h: Move command execution function to global header leds: turris-omnia: Use command execution functions from the MCU driver turris-omnia-mcu-interface.h: Add LED commands related definitions to global header leds: turris-omnia: Use global header for MCU command definitions dt-bindings: leds: cznic,turris-omnia-leds: Allow interrupts property leds: turris-omnia: Document driver private structures leds: turris-omnia: Notify sysfs on MCU global LEDs brightness change platform: cznic: turris-omnia-mcu: Inform about missing LED panel brightness change interrupt feature leds: turris-omnia: Inform about missing LED gamma correction feature in the MCU driver leds: turris-omnia: Use dev_err_probe() where appropriate leds: turris-omnia: Use uppercase first letter in all comments ARM: dts: turris-omnia: Add global LED brightness change interrupt .../leds/cznic,turris-omnia-leds.yaml | 8 + .../dts/marvell/armada-385-turris-omnia.dts | 1 + drivers/leds/Kconfig | 1 + drivers/leds/leds-turris-omnia.c | 318 +++++++++--------- .../platform/cznic/turris-omnia-mcu-base.c | 3 + drivers/platform/cznic/turris-omnia-mcu.h | 130 ------- include/linux/turris-omnia-mcu-interface.h | 148 +++++++- 7 files changed, 312 insertions(+), 297 deletions(-) -- 2.45.2
