On Oct 30, 2024 at 11:17:16 +0530, Vignesh Raghavendra wrote: > Hi > > On 30/10/24 10:15, Dhruva Gole wrote: > > Add another entry in the wkup_conf for the syscon node, and then use > > that for the syscon in opp-table. > > > > Marking entire wkup_conf as "syscon", "simple-mfd" is wrong and needs to > > be addressed similar to how other child-nodes in wkup_conf are implemented > > in the same file. > > > > Signed-off-by: Dhruva Gole <d-gole@xxxxxx> > > --- > > > > Since the driver fixes for ti-cpufreq.c have made it in -next [1], > > The DT fixes for SK-AM62x can be supported with support for legacy > > style DT as well. This has been tested on SK-AM62x [2] > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/cpufreq/ti-cpufreq.c?id=1724ae88efcbcd0daeb203ffeb4a2c0e59f2ddf7 > > [2] https://gist.github.com/DhruvaG2000/40b80cc04a9ac90c86445d6e67ece4cb > > > > Changelog: > > > > Changes in v2: > > - Deleted PATCH to Make the AM625 efuse_offset 0, because with [1] we no > > longer break backward compatibility and hence need to preserve the old > > offset. > > - Link to v1: > > https://lore.kernel.org/linux-arm-kernel/20240902093222.2828345-3-d-gole@xxxxxx/ > > > > --- > > arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 7 ++++++- > > arch/arm64/boot/dts/ti/k3-am625.dtsi | 2 +- > > 2 files changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > > index e0afafd532a5..b2b65e31c7cf 100644 > > --- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > > +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > > @@ -10,7 +10,7 @@ > > &cbass_wakeup { > > wkup_conf: syscon@43000000 { > > Now that the compatible is updated, this needs to be bus@addr > dtbs_check should catch such errors. Oh yes, I'll update this. Good catch. > > > bootph-all; > > - compatible = "syscon", "simple-mfd"; > > + compatible = "simple-bus"; > > Did you also check U-Boot and make sure no regression/update needed? > No, I can do a quick sanity boot till kernel with this DTB in U-boot to check for regressions. Thanks for the review. -- Best regards, Dhruva Gole Texas Instruments Incorporated
