On Sun, Nov 3, 2024 at 5:23 AM Cody Eksal <masterr3c0rd@epochal.quest> wrote: > > On 2024/11/02 8:48 am, Chen-Yu Tsai wrote: > > On Thu, Oct 31, 2024 at 3:03 PM Cody Eksal <masterr3c0rd@epochal.quest> wrote: > >> > >> From: Yangtao Li <frank@xxxxxxxxxxxxxxxxx> > >> > >> A100 perf1 hava MicroSD slot and on-board eMMC module, add support for them. > >> > >> Signed-off-by: Yangtao Li <frank@xxxxxxxxxxxxxxxxx> > >> Signed-off-by: Cody Eksal <masterr3c0rd@epochal.quest> > > > > So I skipped this one since Andre had some questions about the previous > > mmc clock patch. And I believe this one won't work without it? > eMMC (mmc2) works fine after more testing, even without the clock > reparenting patch (in fact, it appears to work more consistently), but > mmc0 and mmc1 require more testing and debugging. I'll deal with > the remaining MMC issues in a future patch. I think it would be better if only the eMMC was enabled. Enabling something that is almost guaranteed to cause data corruption isn't going to be fun for users. ChenYu