On 1/11/2024 21:04, Rob Herring wrote: > On Mon, Oct 28, 2024 at 8:06 PM Nick Chan <towinchenmi@xxxxxxxxx> wrote: >> >> This adds the PMGR node and all known power state subnodes. Since there >> are a large number of them, let's put them in a separate file to include. >> >> Signed-off-by: Nick Chan <towinchenmi@xxxxxxxxx> >> --- >> arch/arm64/boot/dts/apple/t7000-6.dtsi | 4 + >> arch/arm64/boot/dts/apple/t7000-handheld.dtsi | 4 + >> arch/arm64/boot/dts/apple/t7000-j42d.dts | 1 + >> arch/arm64/boot/dts/apple/t7000-mini4.dtsi | 4 + >> arch/arm64/boot/dts/apple/t7000-n102.dts | 4 + >> arch/arm64/boot/dts/apple/t7000-pmgr.dtsi | 641 ++++++++++++++++++ >> arch/arm64/boot/dts/apple/t7000.dtsi | 14 + >> 7 files changed, 672 insertions(+) >> create mode 100644 arch/arm64/boot/dts/apple/t7000-pmgr.dtsi >> >> diff --git a/arch/arm64/boot/dts/apple/t7000-6.dtsi b/arch/arm64/boot/dts/apple/t7000-6.dtsi >> index f60ea4a4a387..77d74d6af1c4 100644 >> --- a/arch/arm64/boot/dts/apple/t7000-6.dtsi >> +++ b/arch/arm64/boot/dts/apple/t7000-6.dtsi >> @@ -48,3 +48,7 @@ switch-mute { >> }; >> }; >> }; >> + >> +&framebuffer0 { >> + power-domains = <&ps_disp0 &ps_mipi_dsi>; >> +}; >> diff --git a/arch/arm64/boot/dts/apple/t7000-handheld.dtsi b/arch/arm64/boot/dts/apple/t7000-handheld.dtsi >> index 8984c9ec6cc8..566346be5b53 100644 >> --- a/arch/arm64/boot/dts/apple/t7000-handheld.dtsi >> +++ b/arch/arm64/boot/dts/apple/t7000-handheld.dtsi >> @@ -10,6 +10,10 @@ >> */ >> >> / { >> + aliases { >> + framebuffer0 = &framebuffer0; > > Looks like an unrelated change. Also, not a standard alias name. So please drop. Alright, (for other SoCs as well) the next version will not have any "framebuffer0" aliases additions. > > Rob Nick Chan