On Thu, Oct 31, 2024 at 10:00:20PM +0100, Konrad Dybcio wrote: > On 29.10.2024 8:52 AM, Johan Hovold wrote: > > + vreg_misc_3p3: regulator-misc-3p3 { > > + compatible = "regulator-fixed"; > > + > > + regulator-name = "VREG_MISC_3P3"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + > > + gpio = <&pm8550ve_8_gpios 6 GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&misc_3p3_reg_en>; > > property-n > property-names > > for consistency, please Sure, will switch these to match the new style that this driver mostly follows (but as we've discussed before, the traditional style that most dt still use for pinctrl is what I used above). > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> Thanks for reviewing. Johan