On Thu, 31 Oct 2024 08:17:40 +0100 ahaslam@xxxxxxxxxxxx wrote: > From: Axel Haslam <ahaslam@xxxxxxxxxxxx> > > These patches aim to improve on the ad5791 driver: > - make use of chip_info / match tables, and drop device enum id. > - Add reset, clr and ldac gpios that have to be set to the correct level in case they > are not hardwired on the setup/PCB. > - simplify probe by using the devm_* functions to automatically free resources. Applied. Thanks, > --- > Changes in v3: > - v2 is missing the version prefix. Im sending v3 just with the added review-by tag. > - Add review-by tag from David Lechner > - Link to V2: https://lore.kernel.org/all/94a03835-bdd1-4243-88c7-0ad85784fe36@xxxxxxxxxxxx/ > > Changes in v2: > - Fix probe error print using uninitialized ret. > - Add documentation for new struct parameters > - Add review-by tags to device tree bindings > - Link to V1: https://lore.kernel.org/all/CAKXjFTPwN2TYW6sq1kj3miZ0f5OqKX0aTk8eGf1sj9TBk1_e=A@xxxxxxxxxxxxxx/T/ > > Axel Haslam (6): > dt-bindings: iio: dac: ad5791: Add optional reset, clr and ldac gpios > dt-bindings: iio: dac: ad5791: Add required voltage supplies > iio: dac: ad5791: Include chip_info in device match tables > iio: dac: ad5791: Add reset, clr and ldac gpios > iio: dac: ad5791: Use devm_regulator_get_enable_read_voltage > iio: dac: ad5791: Use devm_iio_device_register > > .../bindings/iio/dac/adi,ad5791.yaml | 39 ++++ > drivers/iio/dac/ad5791.c | 203 ++++++++---------- > 2 files changed, 131 insertions(+), 111 deletions(-) >