On 30.10.2024 12:50 PM, Dmitry Baryshkov wrote:
> Add board DT file for the Qualcomm Snapdragon AR2 Gen1 Smart Viewer
> Development Kit.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
Please add newlines before status consistently
[...]
> +
> + wcn7850-pmu {
> + compatible = "qcom,wcn7850-pmu";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&wlan_en_state>, <&bt_en_state>;
flip please
[...]
> +
> +&pon_resin {
> + status = "okay";
> +
> + linux,code = <KEY_VOLUMEDOWN>;
and here
[...]
> +
> + ptn3222: redriver@4f {
> + compatible = "nxp,ptn3222";
> + reg = <0x4f>;
> + #phy-cells = <0>;
> + vdd3v3-supply = <&vreg_l2a_3p1>;
> + vdd1v8-supply = <&vreg_l15a_1p8>;
> + reset-gpios = <&tlmm 99 GPIO_ACTIVE_LOW>;
Since I'm nitpicking hard already, please see the property order in romulus.dtsi
Looks good otherwise, thanks!
Konrad
