On 31/10/2024 16:12, Heiko Schocher wrote: > Adding gpio-line-names property works fine for this > device node, but dtb check drops warning: > > 'gpio-line-names' does not match any of the regexes: '-cfg$', 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/pinctrl/semtech,sx1501q.yaml# > > Allow to add property gpio-line-names for this devices. > > Signed-off-by: Heiko Schocher <hs@xxxxxxx> > > --- > checkpatch shows > WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) > 'gpio-line-names' does not match any of the regexes: '-cfg$', 'pinctrl-[0-9]+' No worries, this can be ignored. Warning messages can pass the limit (up to some point). > > Ignored, as it is a make output, which helps to understand the > reason for adding this patch. > > Changes in v2: > patch dt-bindings: pinctrl: sx150xq: allow gpio line naming new in v2 > > .../devicetree/bindings/pinctrl/semtech,sx1501q.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml b/Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml > index 4214d7311f6b..fd0936545bb8 100644 > --- a/Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml > @@ -26,6 +26,10 @@ properties: > reg: > maxItems: 1 > > + gpio-line-names: > + minItems: 1 I think gpio-line-names should always match the actual number of GPIOs for given device. Do you have here devices with 1 gpio? This could be further constrained in if:then sections. Best regards, Krzysztof
