Hi Tudor, On Wed, 30 Oct 2024 at 12:00, Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> wrote: > > > > On 10/25/24 2:14 PM, Peter Griffin wrote: > > v1 of the patch which introduced the ufshcd_vops_hibern8_notify() callback > > used a bool instead of an enum. In v2 this was updated to an enum based on > > the review feedback in [1]. > > > > ufs-exynos hibernate calls have always been broken upstream as it follows > > the v1 bool implementation. > > > > [1] https://patchwork.kernel.org/project/linux-scsi/patch/001f01d23994$719997c0$54ccc740$@samsung.com/ > > you can use the Link tag, Link: blabla [1] Will fix in v3 > > A Fixes tag and maybe Cc to stable? Or maybe you chose to not backport > it intentionally, in which case you have to add: > Cc: <stable+noautosel@xxxxxxxxxx> # reason goes here, and must be present I'll add a cc stable tag, as there is no reason not to backport this fix. > > In order to avoid scripts queuing your patch. It contains "fix" in the > subject, there's a high probability to be queued to stable. > > With these addressed: > Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> Thanks for the reviews! Peter.