Hi Tudor, On Wed, 30 Oct 2024 at 08:56, Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> wrote: > > > > On 10/25/24 2:14 PM, Peter Griffin wrote: > > The values calculated in exynos_ufs_specify_phy_time_attr() are only used > > in exynos_ufs_config_phy_time_attr() and exynos_ufs_config_phy_cap_attr() > > all values set in exynos_ufs_specify_phy_time_attr() are used *only* in > exynos_ufs_config_phy_time_attr(). Or did I miss something? Yes you're right, I'll update the commit message. > > > if EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR flag is not set. > > yep, wonderful. > > > > > Add a check for this flag to exynos_ufs_specify_phy_time_attr() and > > return for platforms that don't set it. > > > > Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx> > > --- > > drivers/ufs/host/ufs-exynos.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c > > index d685d3e93ea1..a1a2fdcb8a40 100644 > > --- a/drivers/ufs/host/ufs-exynos.c > > +++ b/drivers/ufs/host/ufs-exynos.c > > @@ -546,6 +546,9 @@ static void exynos_ufs_specify_phy_time_attr(struct exynos_ufs *ufs) > > struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr; > > struct ufs_phy_time_cfg *t_cfg = &ufs->t_cfg; > > > > + if (ufs->opts & EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR) > > + return; > > + > > t_cfg->tx_linereset_p = > > exynos_ufs_calc_time_cntr(ufs, attr->tx_dif_p_nsec); > > t_cfg->tx_linereset_n = > > tx_linereset_n, rx_hibern8_wait is set but not used anywhere. Can we > remove it? Not related to this patch though. Yes they can be removed if they are unused. Peter
