On 24-10-30 17:02:32, Marc Zyngier wrote: > On Fri, 25 Oct 2024 13:32:24 +0100, > Sibi Sankar <quic_sibis@xxxxxxxxxxx> wrote: > > > > Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE > > is the speed binned variant of X1E80100 that supports turbo boost up to > > 4.3 Ghz. The initial support includes the following: > > > > -DSPs > > -Ethernet (RTL8125BG) over the pcie 5 instance. > > -NVme > > -Wifi > > -USB-C ports > > > > V3: > > * Asked around and looked at the firmware, couldn't find a codename so > > will keep it as DEVKIT. Will update it if someone from the community > > finds something else. > > My machine has the following information as part of its DMI tables: > > Handle 0x0005, DMI type 1, 27 bytes > System Information > Manufacturer: Qualcomm > Product Name: Snapdragon-Devkit > Version: 2.1 > Serial Number: 5 > UUID: 63b5fc8b-9c50-89aa-fd0f-3fcef93dc291 > Wake-up Type: Power Switch > SKU Number: 6 > Family: SCP_HAMOA > > So I guess that Snapdragon-Devkit is another possible name. But given > that it is a bit of a mouthful, devkit, Devkit, or any other variation > on the case would work for me. The point was to have something unique A codename would be unique. Naming it Snapdragon-Devkit (or just devkit) will be confusing since there was already a 2023 devkit (from Microsoft) with the Snapdragon 8cx Gen 3, and probably the next compute platform will also have a devkit as well. So probably "X Elite devkit" could be the right option.. > > > * Update type c roles as reported by ucsi. [Dmitry] > > * Update THUNDERCOMM to Thundercomm. [Dmitry] > > * Update regulator names and sort Order. [Dmitry] > > * Add x1e001DE devkit to the safe list. > > * Mark regulator-nmve as boot enabled. > > > > > > V2: > > * Fix Ghz -> GHz [Jeff] > > * Pick up Ab tag from Rob. > > * Use Vendor in ADSP/CDSP firmware path [Dmitry] > > * Fix reserved gpios [Dmitry] > > * Only port0 supports DRD update the dt accordingly [Dmitry] > > > > Sibi Sankar (3): > > dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows > > firmware: qcom: uefisecapp: Allow X1E Devkit devices > > arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows > > > > .../devicetree/bindings/arm/qcom.yaml | 6 + > > arch/arm64/boot/dts/qcom/Makefile | 1 + > > arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 814 ++++++++++++++++++ > > drivers/firmware/qcom/qcom_scm.c | 1 + > > 4 files changed, 822 insertions(+) > > create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts > > FWIW, I'm running this as part of my KVM test rig with minor changes > to expose the SMMU and allow the ITS on pcie5, and things work as well > as you can expect. FWIW: > > Acked-by: Marc Zyngier <maz@xxxxxxxxxx> > Tested-by: Marc Zyngier <maz@xxxxxxxxxx> > > M. > > -- > Without deviation from the norm, progress is not possible.
