On Wed, Oct 30, 2024 at 07:43:04AM +0100, Krzysztof Kozlowski wrote: > On Tue, Oct 29, 2024 at 08:02:03PM +0100, Stanislav Jakubek wrote: > > Thank you for your patch. There is something to discuss/improve. > > > + interrupt-controller: true > > + spi-max-frequency: true > > This means: > 1. You forgot to ref spi-peripheral-props > 2. This is not needed and use use unevaluatedProperties: false. Ack, will reference spi-peripheral-props. > > Just like all SPI devices. > > Unless this is not SPI? As far as I understand it, it kind of is SPI and kind of isn't. See /schemas/spi/sprd,spi-adi.yaml. > > > > + > > + '#address-cells': > > + const: 1 > > + > > + '#interrupt-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 0 > > + > > + regulators: > > + type: object > > + $ref: /schemas/regulator/sprd,sc2731-regulator.yaml# > > + > > +patternProperties: > > + "^adc@[0-9a-f]+$": > > + type: object > > + $ref: /schemas/iio/adc/sprd,sc2720-adc.yaml# > > + > > + "^charger@[0-9a-f]+$": > > + type: object > > + $ref: /schemas/power/supply/sc2731-charger.yaml# > > + > > + "^efuse@[0-9a-f]+$": > > + type: object > > + $ref: /schemas/nvmem/sprd,sc2731-efuse.yaml# > > I don't think this was merged. You still have dependency. This is in next-20241029, which this patch is based on. > > Try yourself - apply this patch on the maintainers tree and test it. > > You can solve it by listing here compatibles and additionalProperties: > true (see Qcom mdss bindings) > > > > > + > > + "^fuel-gauge@[0-9a-f]+$": > > + type: object > > + $ref: /schemas/power/supply/sc27xx-fg.yaml# > > + > > + "^gpio@[0-9a-f]+$": > > + type: object > > + $ref: /schemas/gpio/sprd,gpio-eic.yaml# > > + > > + "^led-controller@[0-9a-f]+$": > > + type: object > > + $ref: /schemas/leds/sprd,sc2731-bltc.yaml# > > + > > + "^rtc@[0-9a-f]+$": > > + type: object > > + $ref: /schemas/rtc/sprd,sc2731-rtc.yaml# > > + > > + "^vibrator@[0-9a-f]+$": > > + type: object > > + $ref: /schemas/input/sprd,sc27xx-vibrator.yaml# > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - interrupt-controller > > + - spi-max-frequency > > + - '#address-cells' > > Keep consistent quotes, either ' or ". Ack. Thanks for the review, Stanislav > > > + - '#interrupt-cells' > > + - '#size-cells' > > Best regards, > Krzysztof >
