Hello Lee, this is v4 of Turris Omnia LED driver changes. v1, v2 and v3 can be found at https://lore.kernel.org/linux-leds/20240902124104.14297-1-kabel@xxxxxxxxxx/ https://lore.kernel.org/linux-leds/20240903101930.16251-1-kabel@xxxxxxxxxx/ https://lore.kernel.org/linux-leds/20240913123103.21226-1-kabel@xxxxxxxxxx/ Changes since v3: - fixed kernel test robot warning for patch 2 by adding dependency to the TURRIS_OMNIA_MCU module - added Krzysztof's Acked-by to patch 5 - added patch documenting driver private `struct omnia_leds` and `struct omnia_led` - addressed your notes for patch 7 (6 in v3) - added `select TURRIS_OMNIA_MCU_GPIO` to KConfig. The driver already depends on TURRIS_OMNIA_MCU, but for the global brightness changed interrupt it needs the GPIO functionality from the turris-omnia-mcu driver Marek Marek Behún (12): turris-omnia-mcu-interface.h: Move command execution function to global header leds: turris-omnia: Use command execution functions from the MCU driver turris-omnia-mcu-interface.h: Add LED commands related definitions to global header leds: turris-omnia: Use global header for MCU command definitions dt-bindings: leds: cznic,turris-omnia-leds: Allow interrupts property leds: turris-omnia: Document driver private structures leds: turris-omnia: Notify sysfs on MCU global LEDs brightness change platform: cznic: turris-omnia-mcu: Inform about missing LED panel brightness change interrupt feature leds: turris-omnia: Inform about missing LED gamma correction feature in the MCU driver leds: turris-omnia: Use dev_err_probe() where appropriate leds: turris-omnia: Use uppercase first letter in all comments ARM: dts: turris-omnia: Add global LED brightness change interrupt .../leds/cznic,turris-omnia-leds.yaml | 8 + .../dts/marvell/armada-385-turris-omnia.dts | 1 + drivers/leds/Kconfig | 2 + drivers/leds/leds-turris-omnia.c | 291 ++++++++---------- .../platform/cznic/turris-omnia-mcu-base.c | 3 + drivers/platform/cznic/turris-omnia-mcu.h | 130 -------- include/linux/turris-omnia-mcu-interface.h | 148 ++++++++- 7 files changed, 288 insertions(+), 295 deletions(-) -- 2.45.2
