Re: [PATCH v3 1/2] dt-bindings: iio: light: veml6075: document rset-ohms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 29/10/2024 08:33, Krzysztof Kozlowski wrote:
> On Mon, Oct 28, 2024 at 06:14:01PM +0100, Javier Carrasco wrote:
>> The veml6070 provides a configurable integration time by means of an
>> external resistor (Rset in the datasheet) with values between 75 and
>> 1200 kohms.
>>
>> Document rset-ohms to select the integration time.
>>
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
>> ---
>>  .../devicetree/bindings/iio/light/vishay,veml6075.yaml | 18 ++++++++++++++++++
>>  1 file changed, 18 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml b/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
>> index 96c1317541fa..5381a90f7f7e 100644
>> --- a/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
>> +++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
>> @@ -22,6 +22,13 @@ properties:
>>    reg:
>>      maxItems: 1
>>  
>> +  rset-ohms:
> 
> I missed last time this, sorry:
> This looks specific to this device, so missing vendor prefix. Otherwise
> you should use an existing property or make it a generic, IIO property
> in common schema.
> 
> Best regards,
> Krzysztof
> 

This is a device-specific property, so I will rename to

vishay,reset-ohms

Thanks and best regards,
Javier Carrasco





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux