On 10/25/2024 11:44 PM, Konrad Dybcio wrote:
On 25.10.2024 6:08 PM, kernel test robot wrote:
Hi Md,
kernel test robot noticed the following build warnings:
[auto build test WARNING on mtd/nand/next]
[also build test WARNING on broonie-spi/for-next robh/for-next linus/master v6.12-rc4 next-20241025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Md-Sadre-Alam/spi-dt-bindings-Introduce-qcom-spi-qpic-snand/20241021-200849
base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next
patch link: https://lore.kernel.org/r/20241021115620.1616617-7-quic_mdalam%40quicinc.com
patch subject: [PATCH v12 6/8] spi: spi-qpic: add driver for QCOM SPI NAND flash Interface
config: sparc64-randconfig-r073-20241023 (https://download.01.org/0day-ci/archive/20241025/202410252355.ZofaMeku-lkp@xxxxxxxxx/config)
compiler: sparc64-linux-gcc (GCC) 14.1.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410252355.ZofaMeku-lkp@xxxxxxxxx/
smatch warnings:
drivers/spi/spi-qpic-snand.c:1260 qcom_spi_write_page() warn: unsigned 'cmd' is never less than zero.
drivers/spi/spi-qpic-snand.c:1279 qcom_spi_send_cmdaddr() warn: unsigned 'cmd' is never less than zero.
vim +/cmd +1260 drivers/spi/spi-qpic-snand.c
1252
1253 static int qcom_spi_write_page(struct qcom_nand_controller *snandc,
1254 const struct spi_mem_op *op)
1255 {
1256 struct qpic_snand_op s_op = {};
1257 u32 cmd;
1258
1259 cmd = qcom_spi_cmd_mapping(snandc, op->cmd.opcode);
1260 if (cmd < 0)
1261 return cmd;
The robot is right, qcom_spi_cmd_mapping() should return an int, as you
return a negative errno upon failure
Ok will fix in next revision.
Konrad
