On Mon, Oct 28, 2024 at 02:02:49PM +0100, Linus Walleij wrote: > On Thu, Oct 24, 2024 at 8:44 AM Inochi Amaoto <inochiama@xxxxxxxxx> wrote: > > > Add base driver for SG2042 SoC and pin definition. > > > > Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxx> > > This driver is clearly duplicating a ton of code from pinctrl-cv18xx.c. > > We have no interest in having to fix bugs in two places. > > Please factor out the common code and use the same code > in the new driver if you can't make the new driver a simple > subdriver och pinctrl-cv18xx.c. > > Yours, > Linus Walleij I will have a try to abstact the different code and reduce the duplicate. Regards, Inochi
