Hi Troy, kernel test robot noticed the following build warnings: [auto build test WARNING on andi-shyti/i2c/i2c-host] [also build test WARNING on robh/for-next linus/master v6.12-rc5 next-20241028] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Troy-Mitchell/dt-bindings-i2c-spacemit-add-support-for-K1-SoC/20241028-133452 base: https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git i2c/i2c-host patch link: https://lore.kernel.org/r/20241028053220.346283-3-TroyMitchell988%40gmail.com patch subject: [PATCH v2 2/2] i2c: spacemit: add support for SpacemiT K1 SoC config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20241028/202410282041.JgAO0LV0-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241028/202410282041.JgAO0LV0-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202410282041.JgAO0LV0-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): drivers/i2c/busses/i2c-k1.c: In function 'spacemit_i2c_is_last_msg': >> drivers/i2c/busses/i2c-k1.c:340:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 340 | if (i2c->dir == DIR_READ) | ^ Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for GET_FREE_REGION Depends on [n]: SPARSEMEM [=n] Selected by [m]: - RESOURCE_KUNIT_TEST [=m] && RUNTIME_TESTING_MENU [=y] && KUNIT [=m] vim +/else +340 drivers/i2c/busses/i2c-k1.c 337 338 static int spacemit_i2c_is_last_msg(struct spacemit_i2c_dev *i2c) 339 { > 340 if (i2c->dir == DIR_READ) 341 if (i2c->unprocessed == 1 && i2c->msg_idx == i2c->msg_num - 1) 342 return 1; 343 else if (i2c->dir == DIR_WRITE) 344 if (!i2c->unprocessed && i2c->msg_idx == i2c->msg_num - 1) 345 return 1; 346 347 return 0; 348 } 349 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki