On Mon, Oct 28, 2024 at 4:59 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On Fri, Oct 25, 2024 at 06:44:44PM +0800, Fei Shao wrote: > > Add the missing "maxim,dsm_param_name" property in the binding. > > This property specifies the customized DSM parameter binary name. > > > > Signed-off-by: Fei Shao <fshao@xxxxxxxxxxxx> > > --- > > > > Documentation/devicetree/bindings/sound/maxim,max98390.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/maxim,max98390.yaml b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml > > index 5bd235cf15e6..fa4749735070 100644 > > --- a/Documentation/devicetree/bindings/sound/maxim,max98390.yaml > > +++ b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml > > @@ -32,6 +32,10 @@ properties: > > minimum: 1 > > maximum: 8388607 > > > > + maxim,dsm_param_name: > > + description: The DSM parameter binary name (e.g. dsm_param.bin). > > + $ref: /schemas/types.yaml#/definitions/string > > NAK, you cannot document properties post-factum. It's not a property > coming from 2014. > > For me, this is obvious that this is for ACPI and if you want to use it > for DT platforms, go through proper review. > > In any case: NAK for this and other ACPI properties. Acknowledged, I didn't know that. This was directly from a Maxim customer and I guess they didn't remove it when porting from ACPI or something. I'll drop this and update DT in another series. Regards, Fei > > Best regards, > Krzysztof >
