On 10/25/2024 5:30 PM, Krzysztof Kozlowski wrote: > On Fri, Oct 25, 2024 at 09:25:17AM +0530, Manikanta Mylavarapu wrote: >> From: Devi Priya <quic_devipriy@xxxxxxxxxxx> >> >> Add NSSCC clock and reset definitions for ipq9574. >> >> Signed-off-by: Devi Priya <quic_devipriy@xxxxxxxxxxx> >> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx> >> --- >> Changes in V8: >> - Replace bias_pll_cc_clk, bias_pll_ubi_nc_clk with CMN_PLL >> NSS_1200MHZ_CLK and PPE_353MHZ_CLK >> - Remove bias_pll_nss_noc_clk because it's not required. >> - Drop R-b tag > > That's not really a change waranting re-review. > > I wished you did not create here dependency, skipped the header and just > use some number for the clock. Having dependencies does not help anyone: > neither you to get this merged, nor us to see that it was tested. > > Please confirm that this patch was fully tested. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Best regards, > Krzysztof > > Yes, it's fully tested. Thanks & Regards, Manikanta.
