On Fri, Oct 25, 2024 at 06:44:42PM +0800, Fei Shao wrote:
> The associated machine driver is not dependent on the format of DAI link
> node names. This means we are allowed to use more descriptive names
> instead of indices without impacting functionality.
>
> Update the binding to accept arbitrary DAI link names with a "-dai-link"
> suffix. This is the common pattern used by the target (MT8188) and other
> (MT8195, MT8186 etc.) MediaTek-based Chromebooks.
We do not want arbitrary names. Why for example green-batman-dai-link
should be correct? The existing pattern looks wrong. Please read DT spec
and chapter about recommended names.
>
> Signed-off-by: Fei Shao <fshao@xxxxxxxxxxxx>
> ---
>
> .../devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml
> index 701cedfa38d2..2da34b66818f 100644
> --- a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml
> +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml
> @@ -40,7 +40,7 @@ properties:
> name defined in the machine driver.
>
> patternProperties:
> - "^dai-link-[0-9]+$":
> + ".*-dai-link$":
This breaks existing users.
> type: object
> description:
> Container for dai-link level properties and CODEC sub-nodes.
> @@ -112,7 +112,7 @@ examples:
> "Headphone", "Headphone L",
> "Headphone", "Headphone R",
> "AIN1", "Headset Mic";
> - dai-link-0 {
> + hdmi-dai-link {
No. Not really justified.
Best regards,
Krzysztof
