Re: [PATCH v2 2/2] arm64: dts: qcom: Enable USB controllers for QCS8300

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/27/2024 11:14 PM, Dmitry Baryshkov wrote:
On Sun, Oct 27, 2024 at 11:59:44AM +0530, Krishna Kurapati wrote:


On 10/26/2024 11:06 PM, Dmitry Baryshkov wrote:
On Fri, Oct 11, 2024 at 01:16:19PM +0530, Krishna Kurapati wrote:
Enable primary USB controller on QCS8300 Ride platform. The primary USB
controller is made "peripheral", as this is intended to be connected to
a host for debugging use cases.

Signed-off-by: Krishna Kurapati <quic_kriskura@xxxxxxxxxxx>
---
   arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
   1 file changed, 23 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
index 7eed19a694c3..3e925228379c 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
@@ -265,3 +265,26 @@ &ufs_mem_phy {
   	vdda-pll-supply = <&vreg_l5a>;
   	status = "okay";
   };
+
+&usb_1_hsphy {
+	vdda-pll-supply = <&vreg_l7a>;
+	vdda18-supply = <&vreg_l7c>;
+	vdda33-supply = <&vreg_l9a>;
+
+	status = "okay";
+};
+
+&usb_qmpphy {
+	vdda-phy-supply = <&vreg_l7a>;
+	vdda-pll-supply = <&vreg_l5a>;
+
+	status = "okay";
+};
+
+&usb_1 {
+	status = "okay";
+};
+
+&usb_1_dwc3 {
+	dr_mode = "peripheral";
+};

So, can it be used as a USB host controller / connector? What needs to
be done in such a case?

Adding vbus boost pinctrl and changing dr_mode to host must be enough for
this case.

Could you please mention those either in the commie message or in the
comment before the board DT file?


Sure, I can update commit text to add something like the following:

"In case first controller needs to be configured in host mode, X-GPIO to be enabled and dr_mode to be changed accordingly."

But when we add second controller (which I will after SPMI node is done), this commit text would be redundant as the same file would show example for host mode as well.

Regards,
Krishna,




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux