Re: [PATCH v2] dt-bindings: pinctrl: convert pinctrl-mcp23s08.txt to yaml format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof , Himanshu

>>> +
>>> +    i2c {
>>
>>Keep one complete example for i2c and one for spi. This was not in
>>previous patch and change log does not explain why you need three
>>examples.
>
>Okay, I will drop one example of I2C

In ex1: use when you only need basic GPIO and interrupt capabilities 
without additional pin control and in ex2: use when you need pull-up 
resistors on specific GPIO pins or a reset line.

Original bindings state that this node can be implemented in two 
different ways, so we should maintain both examples for reference.

But it's up to you, I trust your expertise on this, Krzysztof

>>> +        #address-cells = <1>;
>>> +        #size-cells = <0>;
>>> +
>>> +        mcp23017: gpio@21 {
>>
>>Drop unused label
> 
>May I know how its unused, AFAIK, Since it's an I/O expanded, it’s referenced elsewhere, so keeping it is necessary for >functionality.

I agree with Himanshu. 
It's definitely used for reset GPIOs, LED pins, or something similar.

Best Regards,
Tarang




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux