On Fri, Oct 25, 2024 at 03:45:07PM +0300, Stanimir Varbanov wrote: > Update brcmstb PCIe controller bindings with bcm2712 compatible > and add new resets. > > Signed-off-by: Stanimir Varbanov <svarbanov@xxxxxxx> > --- > v3 -> v4: > - Dropped Reviewed-by and Acked-by tags because I have to re-work the patch > in order to fix newly produced DTB warnings on the .dts files. > - Account the number of resets for bcm2712 which are differs from bcm7712. > > .../bindings/pci/brcm,stb-pcie.yaml | 21 +++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > index 0925c520195a..df9eeaef93cd 100644 > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > @@ -14,6 +14,7 @@ properties: > items: > - enum: > - brcm,bcm2711-pcie # The Raspberry Pi 4 > + - brcm,bcm2712-pcie # Raspberry Pi 5 > - brcm,bcm4908-pcie > - brcm,bcm7211-pcie # Broadcom STB version of RPi4 > - brcm,bcm7216-pcie # Broadcom 7216 Arm > @@ -175,6 +176,26 @@ allOf: > - resets > - reset-names > > + - if: > + properties: > + compatible: > + contains: > + const: brcm,bcm2712-pcie > + then: > + properties: > + resets: > + minItems: 2 > + maxItems: 2 > + > + reset-names: > + items: > + - const: bridge > + - const: rescal Sigh. Why the opposite order of the existing bindings? I would make the top level: minItems: 1 items: - enum: [perst, rescal] - const: bridge - const: swinit Rob
