Re: [PATCH 3/6] arm64: dts: qcom: sc8280xp-x13s: Drop redundant clock-lanes from camera@10

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/10/2024 18:23, Konrad Dybcio wrote:
On 25.10.2024 5:43 PM, Bryan O'Donoghue wrote:
clock-lanes does nothing here - the sensor doesn't care about this
property, remove it.

Tested-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> # x13s
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
---

drivers/media/platform/qcom/camss/camss.c : camss_of_parse_endpoint_node()

seems to reference it and pass it on to the PHY drivers

Konrad

Yep but that parses the clock-lane indicator in camss ports

&camss {
        vdda-phy-supply = <&vreg_l6d>;
        vdda-pll-supply = <&vreg_l4d>;

        status = "okay";

        ports {
                port@0 {
                        csiphy0_lanes01_ep: endpoint@0 {
                                reg = <0>; // HERE
                                clock-lanes = <7>;
                                data-lanes = <0 1>;
                                remote-endpoint = <&ov5675_ep>;
                        };
                };
        };
};

this patch and its sister patch remove clock-lanes form the sensor

&cci2_i2c1 {
        camera@10 {

		<snip>
                port {
                        ov5675_ep: endpoint {
				clock-lanes = <0>;//HERE
                                data-lanes = <1 2>;
				<snip>
                        };
                };

        };
};

This is removing the camera@10{} clock-lanes not the camss{} clock lanes which you're right is referenced.

---
bod




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux